On Sun, Jan 29, 2012 at 04:58:25PM +0100, Aleksandra Bookwar wrote: > >> >> Hm, lxpanelx was mentioned before on this list. Is there any chance that > >> >> some patches get merged back into lxpanel? > >> > > >> > I was under the impression that someone offered to do that. > > > > That would be pretty awesome! I am willing to help, but my primary > > interest is in some minimal bugfixing for the stable branch, and the > > gtk3 port. However, as I said, I am definitely willing to help. > > It seems my mail has been lost somewhere, so I am reposting it here:
Indeed, it has. Thanks for reposting. > > I've rebased the lxpanelx fork on top of the current lxpanel > master. You can find the result here: > https://github.com/bookwar/lxpanel Wow! Awesome! Two remarks for now: a) I immediately hit a bug in the thermal plugin that was fixed 5 commits after the point you chose to rebase on. (This is my own fault, I know!) Would be great if you could rebase it on an even more recent master. b) The lxpanelx branch and commit ab2b8cbefb in current master have different fixes for the same problem. I think that the fix in the mentioned commit is the correct fix. Not sure how to go about this. What do you think? > > There are three branches: > > 1) master - branch corresponds to the master branch of lxpanel repo, > 2) svn-lxpanelx-filtered - detached branch exported from lxpanelx svn > repo (you don't need it) > 3) lxpanelx - the branch you need, with all the patches cherry-picked > from svn-lxpanelx-filtered branch > > I have reviewed manually all the cherry-picks and edited some of them > to fix the conflicts. So know it can be applied cleanly. I've build > the result into rpm package. You can find srpm made for testing here > http://files.bookwar.info/lxpanel-0.5.8-2.boo.src.rpm. > > It works on my Fedora 16. But there are some issues left: > - wnckpager applet segfaults when you remove it from the panel (I need > to test, if it is the applet bug or bug of rebased version ) > - localization: taskbar plugin interface has number of new strings, so > po-files need to be updated somehow > - AUTHORS and ChangeLog files need some updates also. > > Unfortunately, I am not the experienced C-programmer myself, so it > could be great, if someone could take a closer look into this patchsets. > Henry ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Lxde-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lxde-list
