On Sun, Sep 17, 2006 at 10:26:01PM +0200, Lars Gullik Bjønnes wrote:
> Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> 
> | > The dispatch function called is not the same dispatch function
> | > anymore. There might be a reason why we have decided to go through the
> | > top most dispatch and let that handle the traversement of the dispatch
> | > hierarchy.
> | 
> | And what is that reason? I thought it was just a remnant of some old
> | code practice.
> 
> This code, the dispatch hierarchy is not very old.
> And you have to talk to the creators of this "modern" dispatch thing
> to get the reason, if any.

Not everything in there got cleaned up after things 'worked'

> It is not a different lyxtext that is the problem, but a different
> dispatch. With this change the dispatch hierarchy is entered not at
> the top anymore.

I don't think this is a problem in this particular case as the 
LFUNs are supposed to be handled by this very LyXText. Using the
dispatch in this place rather looks like a 'convienent' wasy to get
certain code being called instead of properly factoring out common code
to be called from there and LyXTxt::dispatch().

Andre'

Reply via email to