Andre Poenitz wrote:
On Mon, Sep 18, 2006 at 10:07:01AM +0200, Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
The dispatch function called is not the same dispatch function
anymore. There might be a reason why we have decided to go through
the top most dispatch and let that handle the traversement of the
dispatch hierarchy.
Abdelrazak> And what is that reason? I thought it was just a remnant
Abdelrazak> of some old code practice.

Please let LyXFunc::dispatch stay the only entering point. For
example, you'll notice that all the update processing is handled
there. Also, it automatically exits when the lfun is actually
disabled, and some code probably relies on that and invokes dispatch
without knowing whether it makes sense.

Than the proper solution would be to factor out the handling code of the
three call LFUNs into real LyXText::functions.

Agreed. It's more work though...

I plan to decorrelate the lyxfunc from LyXView sometimes in the future so I will come back to this at that time (if ever).

Abdel.

Reply via email to