On Sun, Dec 06, 2015 at 09:12:11PM -0500, Scott Kostyshak wrote:
> On Sun, Dec 06, 2015 at 03:08:47PM +0100, Enrico Forestieri wrote:
> > On Sun, Dec 06, 2015 at 11:52:14AM +0100, Georg Baum wrote:
> > 
> > > Jean-Marc Lasgouttes wrote:
> > > 
> > > > Le 06/12/15 00:02, Scott Kostyshak a écrit :
> > > >> There was an issue on Windows that came from not including a .dll. Now
> > > >> that the issue has been fixed, we should decide if we would like to
> > > >> consider removing the .pngs. If we would like to remove the .pngs for
> > > >> 2.2.0 I think we should definitely do this for beta1. Conversely, if we
> > > >> remove the .pngs for beta, I think it would still be OK to add them 
> > > >> back
> > > >> for the final release if we discover problems, as JMarc proposed [1].
> > > > 
> > > > I think we should remove them.
> > > 
> > > Me too. As I wrote in the bug report, the current state does not make 
> > > sense. 
> > > If we do not remove the .pngs for some reason, then we need to change the 
> > > search algorithm to use .png them if loading .svg fails.
> > 
> > The attached script and patch get rid of the unneeded pngs.
> 
> From what I understand, there is support for the change. I think Georg's
> main concern was that on some systems it might not work, but Enrico
> seems confident that it will work even on less commonly used systems and
> even for 4.8.x.
> 
> Enrico, I would say commit. Thanks for the patch.

Done at db363ab1.

-- 
Enrico

Reply via email to