On Friday 30 March 2001 11:58, John Levon wrote:
> Startup FormExternal, then press OK or Cancel, it will segfault
> because ViewBase == 0x0.
>
> Angus, is this fixed in your new FormExternal (I haven't tried) ?
Yes, I think so. It occurs because FormExternal was derived from
FormBaseDeprecated, but the Ok callback defined in forms/form_external.fd
were to C_FormBaseOKCB, not to C_FormBaseDeprecatedOKCB. Similar story for
the Cancel callback.
Now that FormExternal is derived from FormBase and hence ViewBase, this
should all be fine.
Incidentally, if you do check out the current (as in 5 mins ago) cvs and try
it out, could you test FormExternal properly for me. Dekel reported that
changes wouldn't get applied to the inset. I think that's now fixed, but I
can't easily test, since I don't have any of the supported external programs
installed
Many thanks,
Angus
