On Fri, 30 Mar 2001, Angus Leeming wrote:
> Effectively, therefore, these three buttons are
> Apply & Edit file
> Apply & View Result
> Apply & Update result.
that's right: they were based on code from InsetExternal itself.
> This clearly doesn't fit in with the general "inset and popup" philosophy in
> which all changes in the popup are to the local copy of the params struct and
> these are Applied to the inset only at the very end through the OK button.
I agree.
> void ControlExternal::editExternal()
> {
> // fill the local, controller's copy of the Params struct with
> // the contents of the popup's fields.
> view().apply();
>
> // Create a local copy of the inset and initialise it with this
> // params struct.
> InsetExternal ie(params());
>
> ie.editExternal();
>
> // Can the above command change the inset's params?
> // I don't believe it can, but if so, update the local copy
> params() = ie.params();
> }
This should work. The params shouldn't change.
Also, note we differ on the insert semantics as you noted for FormInclude.
This should be changed as well I suppose ...
thanks
john
--
"Nothing would please me more than being able to hire ten programmers and
deluge the hobby market with good software."
- Bill Gates
