On Thu, Jul 17, 2003 at 09:49:05PM +0800, Huang Ying wrote:
> Sorry, I forget the attachment!
+ FRONTEND_INFO=" libgtkmm version: ${GTKMM_VERSION}\n\
+ libglademm version: ${LIBGLADEMM_VERSION}\n"
+ ;;
Whitespace damage and in configure.ac (spaces instead of a tab)
+ if (response == Gtk::RESPONSE_OK)
+ return std::make_pair<bool, string>(true,
Glib::locale_from_utf8(entry.get_text()));
+ else
+ return std::make_pair<bool, string>(false, string());
Can you try and keep to 80 columns please ? e.g.
string responsestr;
if (response == Gtk::RESPONSE_OK)
responsestr = Glib::locale_from_utf8(entry.get_text());
...
+++ lyx-1.4.0cvs_gtk/src/frontends/gtk/codeConvert.C 2003-07-17 20:20:28.000000000
+0800
This file is effectively empty ...
lyx-1.4.0cvs_gtk/src/frontends/gtk/Dialogs.C
This hasn't kept up with current CVS (the "note" dialog)
+Glib::ustring TranslateMarkup(const Glib::ustring& lyxMarkup)
"translateMarkup" please
And "Glib::ustring const &" everywhere.
+bool GMiniBuffer::onFocusIn(GdkEventFocus * /*event*/)
I think I'd prefer
bool GMiniBuffer::onFocusIn(GdkEventFocus *)
there
+ showInfo("[Begging of history]", false);
"Beginning"
+++ lyx-1.4.0cvs_gtk/src/frontends/gtk/GPainter.h
It seems the includes of the Xft headers in the .h can be removed - please prefer to
forward declare structures etc. when possible ?
+GPrint::GPrint(Dialog& parent, string title)
"Dialog & parent" and all other places
+ owner_.getWindow()->draw_drawable(owner_.getGC(),
+ owner_.getWindow(),
+ owner_.xpos(),
+ owner_.ypos(),
+ owner_.xpos(),
+ owner_.ypos() + old_first -
text->top_y(),
+ owner_.workWidth(),
+ owner_.workHeight() -
old_first + text->top_y());
I'm sure there must be a better formatting here !
+ case MenuItem::Submenu :
case MenuItem::Submenu:
These are all minor points. I'm in favour of this patch being applied after
the needed trivial cleanups. Good work !
regards
john
