Thanks for you advice!
> + FRONTEND_INFO=" libgtkmm version: ${GTKMM_VERSION}\n\
> + libglademm version: ${LIBGLADEMM_VERSION}\n"
> + ;;
>
> Whitespace damage and in configure.ac (spaces instead of a tab)
Sorry, I am not very clear about what you said, my english is poor. You
mean I should use whitespaces in the configure.ac, or tab?
> + if (response == Gtk::RESPONSE_OK)
> + return std::make_pair<bool, string>(true,
> Glib::locale_from_utf8(entry.get_text()));
> + else
> + return std::make_pair<bool, string>(false, string());
>
> Can you try and keep to 80 columns please ? e.g.
should I keep the max columns about 80 in all my source code? Is there any rules
in lyx source code about that?
> string responsestr;
>
> if (response == Gtk::RESPONSE_OK)
> responsestr = Glib::locale_from_utf8(entry.get_text());
>
> ...
>
> +++ lyx-1.4.0cvs_gtk/src/frontends/gtk/codeConvert.C 2003-07-17
> 20:20:28.000000000 +0800
>
> This file is effectively empty ...
Yes, it is empty. I keep it empty and exist, because I think perhaps
there will be some other source about other platform should go here.
> lyx-1.4.0cvs_gtk/src/frontends/gtk/Dialogs.C
>
> This hasn't kept up with current CVS (the "note" dialog)
I should do that.
> +Glib::ustring TranslateMarkup(const Glib::ustring& lyxMarkup)
>
> "translateMarkup" please
> And "Glib::ustring const &" everywhere.
ok, I will revise it!
> +bool GMiniBuffer::onFocusIn(GdkEventFocus * /*event*/)
>
> I think I'd prefer
>
> bool GMiniBuffer::onFocusIn(GdkEventFocus *)
>
> there
I think the things in /* and */, can help somebody who want to read
the source. Do you think so?
> + showInfo("[Begging of history]", false);
>
> "Beginning"
sorry for my mistake!
> +++ lyx-1.4.0cvs_gtk/src/frontends/gtk/GPainter.h
>
> It seems the includes of the Xft headers in the .h can be removed - please prefer to
> forward declare structures etc. when possible ?
ok! I think that is a good idea!
> +GPrint::GPrint(Dialog& parent, string title)
>
> "Dialog & parent" and all other places
ok
> + owner_.getWindow()->draw_drawable(owner_.getGC(),
> + owner_.getWindow(),
> + owner_.xpos(),
> + owner_.ypos(),
> + owner_.xpos(),
> + owner_.ypos() + old_first
> - text->top_y(),
> + owner_.workWidth(),
> + owner_.workHeight() -
> old_first + text->top_y());
>
> I'm sure there must be a better formatting here !
Can you show me?
> + case MenuItem::Submenu :
>
> case MenuItem::Submenu:
ok! If this is the rule of lyx.
>
> These are all minor points. I'm in favour of this patch being applied after
> the needed trivial cleanups. Good work !
>
> regards
> john
Excuse me, are there anything like "coding standard" in lyx?
Now, I know the const after the type, the class member name, the
function name, the empty line between functions. Anything else? And are
there some document about that? completely?
Huang Ying
