On Tue, Jul 22, 2003 at 07:50:59PM +0800, Huang Ying wrote:
> > + FRONTEND_INFO=" libgtkmm version: ${GTKMM_VERSION}\n\
> > + libglademm version: ${LIBGLADEMM_VERSION}\n"
> > + ;;
> >
> > Whitespace damage and in configure.ac (spaces instead of a tab)
> Sorry, I am not very clear about what you said, my english is poor. You
> mean I should use whitespaces in the configure.ac, or tab?
You should use tabs. In some places you have currently used spaces
instead.
> > + if (response == Gtk::RESPONSE_OK)
> > + return std::make_pair<bool, string>(true,
> > Glib::locale_from_utf8(entry.get_text()));
> > + else
> > + return std::make_pair<bool, string>(false, string());
> >
> > Can you try and keep to 80 columns please ? e.g.
> should I keep the max columns about 80 in all my source code?
Yes please.
> Is there any rules in lyx source code about that?
Maybe in development/Code_rules
> > +++ lyx-1.4.0cvs_gtk/src/frontends/gtk/codeConvert.C 2003-07-17
> > 20:20:28.000000000 +0800
> >
> > This file is effectively empty ...
> Yes, it is empty. I keep it empty and exist, because I think perhaps
> there will be some other source about other platform should go here.
Then we can add the stuff if we need to ...
> ok, I will revise it!
thanks
> > +bool GMiniBuffer::onFocusIn(GdkEventFocus * /*event*/)
> >
> > I think I'd prefer
> >
> > bool GMiniBuffer::onFocusIn(GdkEventFocus *)
> >
> > there
> I think the things in /* and */, can help somebody who want to read
> the source. Do you think so?
But it's pretty obvious in this case what it is ("event") don't you
think ?
> > + owner_.getWindow()->draw_drawable(owner_.getGC(),
> > + owner_.getWindow(),
> > + owner_.xpos(),
> > + owner_.ypos(),
> > + owner_.xpos(),
> > + owner_.ypos() +
> > old_first - text->top_y(),
> > + owner_.workWidth(),
> > + owner_.workHeight() -
> > old_first + text->top_y());
> >
> > I'm sure there must be a better formatting here !
> Can you show me?
Darn ;) I just prefer something like :
owner_.getWindow()->draw_drawable(owner_.getGC(),
owner_.getWindow(),
owner_.xpos(), owner_.ypos() owner_.xpos(),
owner_.ypos() + old_first - text->top_y(),
...
in these cases, I think it's more readable. Or consider putting it in
another function ...
> Excuse me, are there anything like "coding standard" in lyx?
> Now, I know the const after the type, the class member name, the
> function name, the empty line between functions. Anything else? And are
> there some document about that? completely?
development/Code_rules has some things, but it's not quite complete
thanks,
john
