Joao Luis Meloni Assirati wrote:

> * putenv.diff: allocate space for the exported string and store the
> pointers in a static map<>. Pointers are deleted when a variable is
> overwritten, so the function doesn't leak memory.

IMHO, seems fine (modulo whitespace).
 
> * export-socket.diff: export variables EDITOR and LYXSOCKET when the
> socket is created. Since there is no need of passing the socket address
> through $$a, it is removed from format.C. Xdvi must then be called with no
> arguments, and kdvi works if the editor is defined as 'lyxclient -g %f
> %l'.

1) For maximum flexibility, I would not remove $$a even if it's not needed
for DVI-I-S. I won't apply that part of the patch for now, ok?.

> * export-lyxclient.diff: makes lyxclient work with LYXSOCKET environment
> variable.

This is your pet, so I will apply this.

> * lyxclient.man: manual page for lyxclient. I again ask some native
> english speaker to revise it, please.

2) You are not talking to me ;-). Should I put the manual page in the same
dir development/lyxsocket?

> * socket-qt.diff: bring lyxsocket to qt.
> 
> * socket_callback.{C,h}: class analogous to io_callback for sockets. They
> must be placed under src/frontends/qt2.


3) From lyxsocket.C: "* FIXME: this code apparently will not work on
Windows."
Will this break the build on Windows or only won't work? If it is the
former, we should do something.
 
*** help with 1,2,3 wanted. ***

Thanks, Alfredo


> TODO:
> 
> * make lib/configure detect if there is a --src or --src-specials option
> available for latex or if there is a srcltx.sty package and then set the
> variable
> 
> \srcspecials latexoption "--src-specials"
> 
> or
> 
> \srcspecials package "srcltx.sty"
> 
> (or whatever is best)
> 
> * Make latex generate source specials only when previewing, not when
> exporting DVI. Alfredo, I have been looking at the "flavours" code. Do you
> think that a good solution would be defining a latex + src specials
> flavour?

I really don't know. I think the experts in this area are Angus and JMarc
(and Jose has been working in output formats lately). Let's wait a bit for
their wonderful ideas.

> * forward search.

Cool ;-)


Alfredo


Reply via email to