On Wed, 5 Nov 2003, Alfredo Braunstein wrote:
> Joao Luis Meloni Assirati wrote:
>
> > * putenv.diff: allocate space for the exported string and store the
> > pointers in a static map<>. Pointers are deleted when a variable is
> > overwritten, so the function doesn't leak memory.
>
> IMHO, seems fine (modulo whitespace).
sorry for if(oldptr)... is it the only problem? should I send another
patch?
> > * export-socket.diff: export variables EDITOR and LYXSOCKET when the
> > socket is created. Since there is no need of passing the socket address
> > through $$a, it is removed from format.C. Xdvi must then be called with no
> > arguments, and kdvi works if the editor is defined as 'lyxclient -g %f
> > %l'.
>
> 1) For maximum flexibility, I would not remove $$a even if it's not needed
> for DVI-I-S. I won't apply that part of the patch for now, ok?.
OK, that was my approach with the original patches.
> > * socket_callback.{C,h}: class analogous to io_callback for sockets. They
> > must be placed under src/frontends/qt2.
>
>
> 3) From lyxsocket.C: "* FIXME: this code apparently will not work on
> Windows."
> Will this break the build on Windows or only won't work? If it is the
> former, we should do something.
(It is in socket_callback.h). I just repeated the same comment that was
in io_callback.h. It should read more like "FIXME: will this code work
in windows?". I don't think it will break windows build more than
io_callback.{C,h} already do.
> > * forward search.
>
> Cool ;-)
Indeed :).
Thank you,
Jo�o.
