Joao Luis Meloni Assirati wrote:
>> > * putenv.diff: allocate space for the exported string and store the
>> > pointers in a static map<>. Pointers are deleted when a variable is
>> > overwritten, so the function doesn't leak memory.
>>
>> IMHO, seems fine (modulo whitespace).
>
> sorry for if(oldptr)... is it the only problem? should I send another
> patch?
No need, I've corrected it myself (I had to find some criticism to prove
I've read it, don't you think? ;-)).
>> 1) For maximum flexibility, I would not remove $$a even if it's not
>> needed for DVI-I-S. I won't apply that part of the patch for now, ok?.
>
> OK, that was my approach with the original patches.
Good.
> (It is in socket_callback.h). I just repeated the same comment that was
> in io_callback.h. It should read more like "FIXME: will this code work
> in windows?". I don't think it will break windows build more than
> io_callback.{C,h} already do.
Fine, I'll put the files then.
Thanks, Alfredo
