On Mon, Nov 10, 2003 at 02:59:51PM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > and most of the explicit update() calls in the dispatchers can > > bprobably be removed as well. The dispatch result should take care of > > it... > > Things are looking much better. > > The following seems to be the reason of a few of the bogus insetHits we were > getting while clicking in the main text. Is it right?: > > Index: BufferView_pimpl.C > =================================================================== > RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/BufferView_pimpl.C,v > retrieving revision 1.456 > diff -u -p -u -r1.456 BufferView_pimpl.C > --- BufferView_pimpl.C 10 Nov 2003 13:23:08 -0000 1.456 > +++ BufferView_pimpl.C 10 Nov 2003 13:51:52 -0000 > @@ -933,7 +933,7 @@ bool BufferView::Pimpl::workAreaDispatch > // handle this event. > > // built temporary path to inset > - InsetOld * inset = insetFromCoords(bv_, cmd.x, cmd.y); > + InsetOld * inset = insetFromCoords(bv_, cmd.x, cmd.y + top_y()); > FuncRequest cmd1(cmd, bv_); > DispatchResult res;
I don't really know. I am still a bit confused about coordinates... > There is another problem I think: and it is the outer cursor getting > out-of-sync with where the real action is happening (if the action happends > inside an inset). Like asynchronous inset updates because the conversion finished? This should be harmless, they simply get ignored. But that's ok as they are off-screen anyway. Next time we come to that place, the paragraph (and scrollbar size) is adjusted. The only 'problem' is that the scrollbar position does not match exactly reality, but its 'not that bad'. > There are a few things that rely on that sync, and > shouldn't (fitCursor for instance). Anything else than the scrollbar issues? Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
