Andre Poenitz wrote: >> For instance, in any hit in LyXTexT::checkInsetHit, y is incremented >> by top_y... so clearly checkInsetHit cannot be called in a loop like >> it is. > > Good point. > > Do you know whether we need to modify the value at all?
It's not used now, but it looks as if it had some purpose once. (removed in patch in other thread) >> > It's not bad if we miss an action because the cursor is too far off: >> > It won't be visible anyway. >> >> No, I mean that the cursor recenters around completely wrong >> coordinates sometimes. (i.e., for instance click in the main text, >> scroll with the scrollbar, click somewhere inside an inset, and then >> everything is wrong) > > I can see it. the are still some exceding fitCursor calls. >> I think that the old code used to put the top >> cursor behind the top locked inset or something. > > Does not sound like a nice solution... Not at all. I was trying to understand what happened. > Should we try to use 'absolute screen coordinates' all over the place? > There would be a 'top_y' as we have now (and maybe top_x), but > everything else is relative to this (top_x, top_y) point. I think that all seems to go better now. I'd prefer if we stick with this scheme (insets have coordinates relative to top_y, paragraphs absolute coords, rows relative to paragraph) until we iron out all recently introduced regressions and then think again about it. I think that things are starting to look good... Alfredo
