Georg Baum <[EMAIL PROTECTED]> writes:

| +string Formats::getFormatFromFile(string const & filename) const
| +{


| +     if (filename.empty())
| +             return string();
| +
| +     string const format =
| lyx::support::getFormatFromContents(filename)

This is a wrapper...

is formatlist a member of something, or a global var?

if a function does not need to be a class member it shouldn't be.

less coupling is good.

| Index: src/frontends/controllers/ChangeLog
| ===================================================================
| RCS file: 
/usr/local/lyx/cvsroot/lyx-devel/src/frontends/controllers/ChangeLog,v
| retrieving revision 1.454
| diff -u -p -r1.454 ChangeLog
| --- src/frontends/controllers/ChangeLog       8 Nov 2004 10:54:28 -0000       
1.454
| +++ src/frontends/controllers/ChangeLog       8 Nov 2004 18:22:35 -0000
| @@ -1,3 +1,12 @@
| +2002-06-21  Herbert Voss  <[EMAIL PROTECTED]>
| +
| +     * ControlListing.[Ch]:
| +     * Makefile.am: new gui for inserting sourcecode into a lyxdoc
| +
| +2004-11-08  Georg Baum  <[EMAIL PROTECTED]>
| +
| +     * ControlMath.C: add mod, pmod and pod
| +

This looks wrong...

-- 
        Lgb

Reply via email to