On Jul 3, 2013, at 11:18 PM, Joshua Root <[email protected]> wrote: > On 2013-7-4 01:11 , Jeremy Huddleston Sequoia wrote: >> >> On Jul 3, 2013, at 12:53 AM, Joshua Root <[email protected]> wrote: >> >>> Yes, we should try to get a proper fix in upstream, but running >>> autoreconf isn't any easier than adding this line. >> >> Slightly, but it's more correct and doesn't force us to keep perl5.12 around >> just to satisfy a buggy configure check. > > We don't have to keep perl5.12 around either way. As I mentioned in > #30937, we could do something like: > > configure.env-append INTLTOOL_PERL=[exec cat > ${prefix}/share/intltool/perl_path]
What purpose would it serve other than to be consumed by other Portfiles for
the sole benefit of passing a configure check that shouldn’t be there in the
first place? If we have to edit the Portfiles, I’d rather add ‘use_autoreconf
yes’ as the proper fix than add a new hack.
> But if you're volunteering to remove the check in all the ports that use
> intltool (221 according to 'port echo depends:intltool', maybe not all
> use autoconf but probably most do), I guess that's fine. :-)
I’m just planning on fixing the ones that have determined that they have some
need for INTLTOOL_PERL to be defined (there are about 27 left now, below)
because those are the ones that definitely won’t work with a non-default perl
variant in the current state. The other ~200 ports didn’t set it to begin
with, and they’re no worse off in the current state than they were before the
change.
I’m doing a complete rebuild with +perl5_16 (and also perl5.12 set to error out
to ensure it doesn’t get accidentally pulled in) to see what I run into. I’ll
fix issues as I run into them with my port set. After that, I’ll fix the
remainder.
audio/gmpc/Portfile:configure.env-append INTLTOOL_PERL=${prefix}/bin/perl5.12
audio/tagtool/Portfile:configure.env-append INTLTOOL_PERL=${prefix}/bin/perl5.12
databases/libgda3/Portfile:configure.env-append INTLTOOL_PERL=${configure.perl}
databases/libgda4/Portfile:configure.env-append INTLTOOL_PERL=${configure.perl}
databases/libgda5/Portfile:configure.env-append INTLTOOL_PERL=${configure.perl}
gnome/file-roller/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/gnome-keyring/Portfile:configure.env
INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/gnome-mime-data/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/gnome-themes/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/libbonobo/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/libbonoboui/Portfile:configure.env INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/libgnomecanvas/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/libgnomeui/Portfile:configure.env INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/nautilus/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
gnome/oaf/Portfile:
ac_cv_path_INTLTOOL_PERL=${prefix}/bin/perl5 \
gnome/zenity/Portfile:configure.env-append INTLTOOL_PERL=${prefix}/bin/perl5.12
graphics/inkscape/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
x11/gtk-engines2/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
x11/gtkspell2/Portfile:configure.env-append INTLTOOL_PERL=${prefix}/bin/perl5.12
x11/xkeyboard-config/Portfile:configure.env-append
INTLTOOL_PERL=${prefix}/bin/perl5.12
xfce/xfce-utils/Portfile: INTLTOOL_PERL=${prefix}/bin/perl5.12
xfce/xfce4-appfinder/Portfile:configure.env
INTLTOOL_PERL=${prefix}/bin/perl5.12
xfce/xfce4-session/Portfile:configure.env INTLTOOL_PERL=${prefix}/bin/perl5.12
xfce/xfce4-settings/Portfile:configure.env
INTLTOOL_PERL=${prefix}/bin/perl5.12
xfce/xfdesktop/Portfile:configure.env INTLTOOL_PERL=${prefix}/bin/perl5.12
xfce/xfprint/Portfile:configure.env INTLTOOL_PERL=${prefix}/bin/perl5.12
xfce/xfwm4/Portfile:configure.env INTLTOOL_PERL=${prefix}/bin/perl5.12
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ macports-dev mailing list [email protected] https://lists.macosforge.org/mailman/listinfo/macports-dev
