Gosh, I should probably subscribe to this list. For my GitHub support, I've actually found relatively few places (so far) where I've felt the need to substantially hook into what Magit is currently doing. That said, I haven't yet tackled anything that would involve adding new sections, modifying existing actions, and so forth. Most of the extensions proposed by Yann look good to me on that front.
I'm a little iffy about magit-define-command, though; it seems like that use-case is adequately handled by advice. Is there any reason to use a custom macro rather than advice in this case? One thing that has been a bit painful for me, and that I could foresee becoming a bigger problem in the future, is the keybinding namespace. Magit has is pretty well saturated; for my GitHub stuff, I'm using the apostrophe as a prefix character, but there are only so many of those that are currently unused. It would be nice if Magit supplied some guideline as to appropriate keybindings for extensions to use. - Nathan On Jun 27, 11:44 am, Philip Jackson <[email protected]> wrote: > At Sat, 26 Jun 2010 14:58:04 +0200, > > Yann Hodique wrote: > > Now if there is any interest in porting this upstream (with necessary > > changes, the patch is not complete, just sufficient for what I really > > needed), I'm willing to do what it takes to go there properly. > > After all, that would *also* make my life easier not to have to maintain > > this as an external patch ;) > > You have my support! If you can rebase on master I'll start using your > branch and that way will hopefully be able to give feedback according > to real world use. > > nex3 is wanting to add github support, I wonder if he has anything to > say about this? > > Cheers, > Phil
