On Mon, Jul 5, 2010 at 2:57 AM, Yann Hodique <[email protected]> wrote:
> Hi, > thanks for your comments. Your GitHub support looks very nice, I shall > have a deeper look :-) > About advising functions, I agree this is the way to go when you stay > external to the code. > Still, it can quickly become a maintenance nightmare, when the > underlying functions evolve out of control. Since this patch intends > to go upstream, I think it'd be more robust to rely on the proper set > of hooks. > See relevant section from the Elisp manual (a.k.a. Bible ;-)) > > *Usage note:* Advising a function can cause confusion in debugging, > since people who debug calls to the original function may not notice > that it has been modified with advice. Therefore, if you have the > possibility to change the code of that function (or ask someone to do > so) to run a hook, please solve the problem that way. Advice should be > reserved for the cases where you cannot get the function changed. > Ah, good point. Totally agree. I was more or less considering proposing to enforce > extension bindings into dedicated maps (maybe with "#" or "&" prefix). > Generally speaking I think some reworking of the global map will be > unavoidable. > I'm not too keen on "#" and "&", since they require both shift and a number key, which is a bit of a reach (especially if you're going to be using it a lot). I chose the apostrophe because it's right there on the home row, and thus easily accessible. C-c might also be a good prefix, with subsequent letters as namespaces.
