It sounded cool, so I tried it out. Certainly appears to work with my
version of magit, which is master as of two days ago. Thanks!

Christopher Allan Webber writes:

> By the way, I built this tool some time ago, and never really
> documented/released it.
>
> Here it is:
>   http://gitorious.org/magit-review/
>
> Note: I don't know if this works on present versions of magit.  I'm
> running an older version, and it works there... commit
> 45712322c1bd713a4172976bc40bb0d92366e410 specifically!
>
> It's a lot like magit-wazzap, except that you move things in and out of
> states (like: ignore this, there wasn't anything new last time I
> checked, or "put this on my review queue") and filters (which show
> *only* branches that match the specified states).  The metadata is
> stored in .git/info/magit-review.
>
> A bit of expanded docs from the README.org file:
>
> -----
> * About magit-review
> ** Motivation
>
> For a long time I used magit-wazzap to handle all my code reviews.
> magit-wazzup is awesome... who doesn't want a buffer where they can
> see all branches with new commits for them to check out at once?
>
> But I found that as my project grew, magit-wazzup failed to scale for
> me:
>  - It was too slow.  My project had about 500 or so branches and
>    magit-wazzup would check *all* of them if they had new commits and
>    format them all for display.  magit-wazzup had an interface to mark
>    something as "ignored" but it didn't really work for me because the
>    branches that should have been ignored didn't show up for me to
>    ignore them anyway!
>  - I also found magit-wazzup's ignore tool annoying because I didn't
>    have a nice way to double check later that I really wanted things
>    that were ignored to stay ignored.
>  - Sometimes I wanted to mark a few branches as "I need to review
>    these" and jump to a limited view of wazzup so I could just focus
>    on the branches I knew needed attention.
>
> If these irritations sound familiar to you, you might like
> magit-review (if not, you might want to just stick with magit-wazzup;
> it's admittedly slightly simpler).  And if you already like
> magit-wazzup, you'll be happy to see that magit-review basically works
> the same way, with just a few small enhancements.
>
> ** magit-review's strategy
>
> magit-review works pretty much the same as magit-wazzup except that it
> adds two features: states and filters.  You can mark a branch with
> some sort of state (magit-review will serialize this so that it's
> remembered) and apply a filter so that only branches that match that
> state actually show up.  For more information on how to actually make
> use of that strategy, read on.
>
> ----
>
> You can find the code here:
>   [email protected]:cwebber/magit-review.git
> or here:
>   http://gitorious.org/magit-review/
>
> (Note: I normally use gitorious but I am trying to get an understanding
> of what it's missing in comparison to GitHub :))
>
> Christopher Allan Webber writes:
>
>> Rémi Vanicat writes:
>>
>>> I didn't use wazzup anymore, but I've already think about it, and I
>>> believe a solution would be to not update the buffer when one ignore a
>>> branch, but to just remove it, of visually mark it is now ignored, and
>>> wait for the user to explicitly update the buffer before doing it. It
>>> would make ignoring branch far less painful
>>
>> This would be helpful, though I think I need more than this.  For
>> example, it's only easy to see something should be marked as ignorable
>> if it still shows up on my wazzap list.  I'm writing this email in the
>> car, but for a repository with 336 branches it takes 7.5 seconds to run
>> merge-base on each of them, which effectively for all the branches that
>> don't show up and aren't explicitly ignored, is something that happens.
>> On my desktop I know I have about 4 times as many branches as
>> this... it's just way too much to manage.
>>
>> I've been thinking of writing a new mode which is basically like an
>> enhanced wazzap mode for people who are crazy like me and just have tons
>> and tons of branches to go through and review.  I'm thinking of calling
>> it magit-reviewer.  Basically, it would have these features:
>>
>>  - Be able to mark things as ignored (like already exits in
>>    magit-wazzap) but in two differen ways: ignored unconditionally, or
>>    ignored under the premise that there's nothing new in this branch to
>>    look at anymore (if that changes, in the branch-reviewing mode that
>>    will be flagged for reconsideration)
>>  - Be able to mark things as being tracked.  Sometimes I have a queue of
>>    things I'm reviewing, and I just want to review those and be able to
>>    move things in and out of that review queue.  This will make things a
>>    lot faster also... refreshing a whitelist based wazzap type interface
>>    as opposed to a blacklist type should be much faster because there's
>>    less to check for.
>>  - The ability to change your filter: view just tracked stuff?  View
>>    everything?  Check for branches that might have new things that
>>    aren't tracked and possibly move them onto the list?
>>  - Should split things visually into said categories of tracked,
>>    ignored, has-new-but-not-tracked, etc.
>>
>> Is this interesting to anyone else?  I'll probably be writing it
>> regardless... I just can't keep up with my workload without it.  Would
>> be interesting to know if it would be helpful to anyone else though.
>>
>>  - cwebb

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to