On Sat, 3 Aug 2013 02:15:59 +0530, Ramkumar Ramachandra <[email protected]> wrote: > On a related note, I've noticed that the repository-detection in magit > is not so good. When editing symlinks for instance, magit can't tell > the repository without vc-follow-symlinks; but since we're all using > magit anyway, might as well turn off the deprecated vc stuff, no? > Maybe implement vc-follow-symlinks in magit, and turn off vc for a > minor perf boost?
I'm not sure I understand what you mean. Is it about `vc-find-file-hook' failing to issue a warning when following a tracked symlink in one repo to a tracked regular file in another repo, even with `vc-follow-symlinks' set to nil ? Actually, the only reason we run `vc-find-file-hook' at all is to update the modeline (see commits 51a1b6d8 and 51fffcb3), and everything it does besides that should be considered unintended side-effects AKA bugs :) And AFAIK, inter-repo symlinks are an obscure corner case anyway. But if you happen to know of some (sane) use cases, I'd gladly be proven wrong! Either way, feel free to open an issue [1] about it. Peace -- Pieter [1] https://github.com/magit/magit/issues/new -- --- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
