Pieter Praet wrote: > Actually, the only reason we run `vc-find-file-hook' at all is to update > the modeline (see commits 51a1b6d8 and 51fffcb3), and everything it does > besides that should be considered unintended side-effects AKA bugs :)
Ah, thanks for digging that out. > And AFAIK, inter-repo symlinks are an obscure corner case anyway. > But if you happen to know of some (sane) use cases, I'd gladly be > proven wrong! Uh, nothing as obscure. Simplest usecase: I have a "dotfiles" repository with $HOME/.gitconfig, $HOME/.zshrc etc. being symlinks to $HOME/dotfiles/*. Without vc-follow-symlinks, emacs warns about the file really being a symbolic link to a version-controlled-file and magit-status asks you to specify the repository by hand. With vc completely turned off using (setq vc-handled-backends nil), it doesn't display the warning but magit-status still can't detect the repository. It's probably not the right idea to strip out the vc dependency, since users might expect some minimal uniformity between git and non-git repositories. Perhaps we should turn on vc-follow-symlinks on in magit, since vc-find-file-hook does the resolution anyway (and throws the computation away unless this variable is set)? Is there any case when the user does _not_ want the symlink to be followed? -- --- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
