Hi all, Firstly many thanks for all your awesome work on magit! It is a massive help to me on a daily basis.
I just updated to the latest git version, and I see a big change in the workflow involved in making a commit. Previously, four keystrokes (including Shift) would deal with the use case I need 90% of the time: `c' to drop me straight into the commit log buffer, and `C-c C-c' when I'd finished writing the commit log. However, with the new workflow, there is an extra commit options menu I have to go through the majority of the time even though I don't need any of the options. Then it appears to invoke emacsclient in order to open a commit log buffer, which means I now have to indicate that I've finished editing via `C-x #' which is more awkward to type. This has other disadvantages too: - A git process is started immediately, and then blocks until the emacsclient process completes. This means that no other git operations are possible until you abort or complete the commit! - The only way of aborting a commit is to empty the buffer and then type `C-x #', which is more effort than a simple `C-x 0' or similar. - If I abort in this manner, I get an ugly "git exited abnormally with code 1" error message. - If nothing is staged, you have to type `-A' instead of simply answering `y' to the prompt which used to exist. - If I close the commit log buffer's window, I can no longer restore it by typing `c' again from the main Magit buffer. - Invoking emacsclient from within emacs, just in order to open a new buffer?!?!! Surely that is just inviting breakage. I'm sorry to bring a negative opinion into the group on my first post, but this seems like a large step backwards in the interface, and I'm really puzzled why it was made. I searched in several places for some announcement or NEWS file which would explain the change, but couldn't find anything. It seems that there used to be a NEWS file a long time ago, but it was removed in 2010 with a commit message "Removed unneeded files". I did finally locate https://github.com/magit/magit/issues/675 (by searching the source for one of the strings which appears in the new interface, and running git annotate on that). AFAICS it appears to be closely related to the above, but it's long and complex and would take me a long time to unravel. So I wanted to ask: 1. Am I missing something or does this new design genuinely suffer from the above issues? 2. Maybe there are signficant advantages to the new way which I didn't notice yet? 3. Is there a way to solve the issues I list? 4. Or am I the only one who is bothered by them? 5. Is it possible to make `C-c C-c' bound to `server-edit' in the emacsclient buffer by default, to minimise the amount of muscle memory that long-time magit users have to re-program? Many thanks! Adam P.S. Sorry for the rich text message. I couldn't figure out how to persuade Google Groups to let me compose in plain text, which really sucks :-( -- --- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
