Adam Spiers <[email protected]> writes:

[...]
> I think it would be great if more of these design discussions happened
> on this list rather than in a pull request, since a threaded
> discussion is easier to follow than a huge linear one.

+1 In my opinion, mailing lists are a better forum for development
   discussion than the github pull request comment thread UI.

[...]
>
>   - `magit-log-edit-mode' was the mechanism magit used to provide for
>     making commits (the one where `c' immediately opened a new
>     buffer).
>
>   - `git-commit-mode' is the new mechanism.  #675 also introduces
>     magit-key-mode-popup-committing which provides integration with it
>     via a pop-up menu, in line with many other existing magit
>     operations called magit-key-mode-popup-something.
>

I used to use the following to customize my commit edit buffer to help
conform to git commit log style guidelines (first line <=50 chars and
all others <=73).

    ;; -*- emacs-lisp -*-
    (add-hook 'magit-log-edit-mode-hook
              (lambda ()
                (column-marker-1 51)
                (column-marker-3 73)
                (set-fill-column 72)))

The commit edit log is now in `fundamental-mode', and I can find no hook
run when this buffer is opened.  What would be the recommended way to
re-enable such customization?

Thanks,

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to