Adam Spiers wrote:
> Firstly many thanks for all your awesome work on magit!  It is a massive 
> help to me on a daily basis.

Indeed.

> I just updated to the latest git version, and I see a big change in the 
[...]

I also updated to the git version, because I updated to a recent emacs
snapshot on my laptop, which didn't really feel like working with the
magit version from ELPA. The git version fixes that, so here I am. :)

> However, with the new workflow, there is an extra commit options menu I 
[...]

Personally, I don't mind the extra pop-up. "c c" or "c"... doesn't make
much of a difference to me.

Here is one (or rather two) issue(s), I'm seeing:

  - I mainly use emacs in terminals. The GUI version (with enabled emacs
    server mode) didn't present these issues to me.

  - In the status-buffer, I stage some changes, and hit "c c". Now I'm
    dropped into a log-editing buffer with some _older_ commit message.
    In the GUI version of emacs I was dropped into a buffer, that had a
    descriptive comment preloaded - I suppose that's the intended
    behaviour. This is the first issue.

  - Editing the commit message went fine otherwise. The highlighting
    makes sense; and things like "C-c C-s" for adding a Signed-off tag
    worked as well.

  - Now, when I'm done I hit "C-c C-c" (not "C-c #" like in the GUI
    version, I don't even try to enable server-mode in a terminal
    emacs - so there's no point in using `server-edit'), and it sure
    proceeds with the commit and kills the editing window. Good. But
    before, it also switched back to the magit-status buffer and
    _refreshed_ it. This doesn't happen in my terminal emacs sessions
    anymore, which is rather inconvenient. (In the GUI version, I used
    "C-x #" to invoke `server-edit' and then everything was switched
    around and refreshed like I expected.) - This is the 2nd issue.

So, that's what I found.

I skimmed through the thread so far and I think I didn't see these
issues being reported yet. I may have missed something. Or maybe they
were reported to your bug-tracker over at github. If so, I apologise for
not looking close enough. In that case, please point me to the relevant
discussion.


Regards, Frank

-- 
There are no threads in alt.binaries.pictures.erotica,
so there's no gain in using a threaded news reader.
                                     -- unknown source

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to