On Fri, 4 Oct 2002 20:46:31 +0200 (CET) Vadim Zeitlin
<[EMAIL PROTECTED]> wrote:
> [sorry for delay with the reply, I can only blame once again my PhD for
> it]
Gee, if you're going to be that way... <G>
> On Wed, 25 Sep 2002 23:02:28 -0700 (Pacific Daylight Time) Michael A
> Chase <[EMAIL PROTECTED]> wrote:
>
> MAC> The attached patch probably shouldn't be applied since I haven't made the
> MAC> GUI changes you suggested yet, but I wanted to show you what I have so far
> MAC> to make sure I'm not too far off base.
>
> No, everything seems very good for me. I didn't test the code so I could
> have missed something while reading it but if it works I think it should be
> applied as globally this is exactly what I'd have done myself.
Thanks. I'll be trying to compile again this weekend, so I should catch
catestrophic typos then.
> MAC> > I think you only need 2 new OAC_T_* values, e.g. OAC_T_SetFlag and
> MAC> > OAC_T_ClearFlag -- or maybe just one if you can combine both actions
> MAC> > somehow. You're right that the encoded Settings string uses these values
> MAC> > (which is why you shouldn't change their numeric values!) but ORC_T_ is for
> MAC> > the new tests, so why do you need it?
> MAC>
> MAC> As long as I was messing with the flags, I thought being able to
> test them
> MAC> would be handy too, so I added a flag("x") test (ORC_T_FlagSet).
>
> I'd call it has_flag() or is_flag_set() but it's just me.
That can be done and it will make some of the internal function names more
distinct.
> MAC> I couldn't find where in the GUI code an unused array entry would be
> MAC> skipped. In src/gui/wxFiltersDialog.cpp, it looks like the entire *_tTypes
> MAC> arrays get passed to wxChoice(). I haven't figured out yet how m_Type or
> MAC> m_Where could tell the GUI not to display certain of their elements. It
> MAC> looks like a validator might do the trick, but that's probably more work
> MAC> than it's worth and I'm not sure whether that would throw off the selection
> MAC> indexes.
>
> It probably would.
I thought so. I haven't done anything with the GUI yet, but this confirms
my planned approach. It means separate sets of enums and arrays for
checking and setting flags, each will be identical to the corresponding
array except for a couple exclusions.
> MAC> I added a bit in ORC_T_Flags[] and OAC_T_Flags[] so it will be easier to
> MAC> identify which tests and actions aren't implemented.
>
> It's a good start, thanks. I'll try to look at the GUI side of the things
> later although, knowing me, you probably understand that it could be much
> later...
Considering that wxWindows doesn't appear to have a way to disable a member
of a selection list without removing it, those bits will probably be a
solution looking for a problem. They ought to be useful somewhere
though...
> MAC> I have not tried to compile the changed code, so there may be some syntax
> MAC> errors. At this point, I'm more interested in having you take a look at
> MAC> what I'm trying to see if it makes any sense. I'll be tackling the GUI
> MAC> code tomorrow now that I think I understand what needs to be added.
>
> Have you had any luck/time with the GUI? Don't hesitate to ask if you have
> any problems.
I bounced a couple times trying to compile wxWindows under Cygwin. I had
been planning to move to Linux for a while and that was just one of the
straws. I have finally started moving, I built a wxGTK rpm from CVS
sources using the instructions in tn0013.txt last night. I hope to try
Mahogany this weekend.
--
Mac :})
** I normally forward private questions to the appropriate mail list. **
Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Mahogany-Developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/mahogany-developers
