I just uploaded my candidate patch to http://home.ix.netcom.com/~mchase/M-641-mac-1.patch . It's about 38K, so I wanted some comments before I sent it to the list or Bugzilla.
This patch adds one test (hasflag) and three actions (setscore, setflag, and clearflag) to message filters and the associated dialog. There is a more detailed list of the changes at the top of the patch. There are a couple issues left over below that I would especially like comments on before I submit the final patch. On Mon, 14 Oct 2002 08:38:21 -0700 (PDT) Michael A Chase <[EMAIL PROTECTED]> wrote: > If I hide the argument instead of just disabling it, I should be able to > remove the code for clearing the argument when it is not being used; that > would allow the value to persist even if the user temporarily stops at a > test or action that is unimplemented or doesn't use the argument. I > changed the UpdateUI() methods to always enable/disable and show/hide the > argument, where, and buttons based on the test or action. Is this > acceptable, or shold I leave the unused controls visible but disabled as > long as their realestate isn't being used by another control? I left the argument erase code in, but could remove it very easily. I think hiding the controls is better than blotting out the string. > The searched flag doesn't appear to be useable. It doesn't show up in the > folder view when I set it. I haven't completed testing, but it also > doesn't appear to get set when I set it. I'm considering just not making > it available, but if it will become useful, I should include it. Should > I? I am still puzzled by this one. I have left "S" in for now, but could remove it easily. The enum values don't appear anywhere outside wxFilterDialog.cpp, so there won't be much impact either way. > The (setscore) action is the last action in the action select list. The > argument control doesn't appear to hide or disable when I select (setscore) > even though it is unimplemented and I have UpdateUI() written to hide and > disable all controls when an unimplemented action is selected. This may be > a boundary condition. I will be doing more testing to find out. Fixed. There appeared to be some unprintable character in the OAC_T_Flags entry. When I cut-and-pasted from another entry, the problem went away. -- Mac :}) ** I normally forward private questions to the appropriate mail list. ** Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.html Give a hobbit a fish and he eats fish for a day. Give a hobbit a ring and he eats fish for an age. ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Mahogany-Developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/mahogany-developers
