I have uploaded the patch again with a new file name as http://home.ix.netcom.com/~mchase/M-641-mac-2.patch . I think I have taken care of all of Vadim's comments.
I have two questions at the end of the long summary. They are related to the patch, but answers are not required before the patch is committed. Short summary: Adds one test (hasflag) and three actions (setscore, setflag, clearflag) to the message filters. Long summary from the top of the patch file: # In include/MFilter.h: # Add enum values ORC_T_HasFlag, OAC_T_SetFlag, OAC_T_ClearFlag, and # OAC_T_SetScore. # Add enum types MFDialogHasFlag and MFDialogSetFlag. # Rename enum value OAC_T_ChangeScore to OAC_T_AddScore. # Change argument type for FilterTestNeedsArgument() and # FilterTestNeedsTarget(). # Add declarations for FilterTestImplemented(), FilterActionNeedsArg(), # FilterActionUsesColour(), FilterActionUsesFolder(), # FilterActionMsgFlag(), and FilterActionImplemented(). # Wrap some long lines. # # In src/classes/MFilter.cpp: # Add ORC_T_HasFlag entry to ORC_T_Names[]. # Add comments giving enum symbols to ORC_W_Names[],OAC_T_Names[], # and OAC_T_Flags[]. # Add bit ORC_F_Unimplemented to ORC_T_Flags. # Add bits OAC_F_Colour, OAC_F_Folder, OAC_F_MsgFlag, and # OAC_F_Unimplemented to OAC_T_Flags[]. # Add checks for USE_PYTHON, USE_HEADER_SCORE. # Change argument type for FilterTestNeedsArgument() and # FilterTestNeedsTarget(). # Add FilterTestImplemented(), FilterActionNeedsArg(), # FilterActionUsesColour(), FilterActionUsesFolder(), # FilterActionMsgFlag(), and FilterActionImplemented() to report bits in # ORC_T_Flags[] and OAC_T_Flags[]. # Replace bit tests against OAC_T_Flags[] with function calls. # Wrap some long lines. # # In src/gui/wxFilterDialog.cpp: # Add comments giving enum symbols to ORC_Types[], ORC_Where[], # ORC_Logical[], and OAC_Types[]. # Add ORC_Msg_Flag[] and OAC_Msg_Flag. # Add checks for USE_PYTHON, USE_HEADER_SCORE. # In OneCritControl:: # Change GetArgument to include m_choiceFlags. # Add m_choiceFlags. # Change UpdateUI() to use FilterTest*() functions so it is controlled by # ORC_T_Flags[]. # ??? Remove code to clear argument string??? # Change SetValues() to handle m_choiceFlags. # In OneActionControl:: # Change SetValues() to handle m_choiceFlags. # Change GetArgument() to include m_choiceFlags. # Add m_choiceFlags. # Change UpdateUI() to use FilterAction*() functions so it is controlled # by OAC_T_Flags[]. # ??? Add code to clear argument string??? # Add call to DoUpdateUI() to wxOneFilterDialog::TransferDataToWindow(). # Wrap some long lines. # # In src/modules/Filters.cpp: # Add func_hasflag(), func_setscore(), func_do_setflag(), func_setflag(), # and func_clearflag(). # Add new functions, except func_do_setflag(), to list of builtin functions. # Wrap some long lines. # # Questions: # Can I remove the code that erases the test and action argument if it isn't # being used? # Why is OAC_T_Illegal not -1? -- Mac :}) ** I normally forward private questions to the appropriate mail list. ** Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.html Give a hobbit a fish and he eats fish for a day. Give a hobbit a ring and he eats fish for an age. ------------------------------------------------------- This sf.net email is sponsored by: viaVerio will pay you up to $1,000 for every account that you consolidate with us. http://ad.doubleclick.net/clk;4749864;7604308;v? http://www.viaverio.com/consolidator/osdn.cfm _______________________________________________ Mahogany-Developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/mahogany-developers
