On Tuesday 17 February 2009, Grant Ingersoll wrote: > Hmm, looks like the tarballs aren't quite right in that the pom > modules aren't named the same as the directories, so mvn compile > doesn't work from the top.
If I understand you correct, you want the sub directories in the tarball named
just like the directories in the source tree. NOT like the artifacts
generated by maven. I have played around a little with the assembly
configuration. See patch attached to this mail*.
> doesn't work from the top. I'll try to fix up this week. Would
> _really_ appreciate other feedback on what works, etc.
Some tiny little feedback from what I just saw:
The README.txt refers the user to the wiki for documentation and getting
started (good), but also to a directory named doc that should be part of the
distribution. I don't see such a directory.
I again tried to run the taste-webapp as some kind of sanity check. If I use
the one from the distribution it fails and tells me to set the Recommender
class in the properties file. I do not know whether this is intended
behaviour. But to me it seemed odd that I needed to check out the sources,
and edit the properties file to make the example webapp run. Maybe it would
be better to just provide a default configuration?
Isabel
* Just in case the attachment is blocked, the following snippet should give
you a hint on what I have done:
<include>org.apache.mahout:mahout-core</include>
</includes>
<binaries>
- <outputDirectory>mahout-core</outputDirectory>
+ <outputDirectory>core</outputDirectory>
<unpack>false</unpack>
</binaries>
<sources>
+ <outputDirectoryMapping>core</outputDirectoryMapping>
<fileSets>
<fileSet>
--
And 1.1.81 is officially BugFree(tm), so if you receive any bug-reports on it,
you know they are just evil lies. -- Linus Torvalds
|\ _,,,---,,_ Web: <http://www.isabel-drost.de>
/,`.-'`' -. ;-;;,_
|,4- ) )-,_..;\ ( `'-'
'---''(_/--' `-'\_) (fL) IM: <xmpp://[email protected]>
Index: maven/mahout-assembly.xml
===================================================================
--- maven/mahout-assembly.xml (revision 745940)
+++ maven/mahout-assembly.xml (working copy)
@@ -27,10 +27,11 @@
<include>org.apache.mahout:mahout-core</include>
</includes>
<binaries>
- <outputDirectory>mahout-core</outputDirectory>
+ <outputDirectory>core</outputDirectory>
<unpack>false</unpack>
</binaries>
<sources>
+ <outputDirectoryMapping>core</outputDirectoryMapping>
<fileSets>
<fileSet>
<!--<directory>core</directory>-->
@@ -38,7 +39,6 @@
<include>src/**</include>
<include>pom.xml</include>
</includes>
- <!--<outputDirectory>mahout-core</outputDirectory>-->
</fileSet>
</fileSets>
</sources>
@@ -48,13 +48,14 @@
<include>org.apache.mahout:mahout-examples</include>
</includes>
<binaries>
- <outputDirectory>mahout-examples</outputDirectory>
+ <outputDirectory>examples</outputDirectory>
<unpack>false</unpack>
</binaries>
<sources>
+ <outputDirectoryMapping>examples</outputDirectoryMapping>
<fileSets>
<fileSet>
- <!--<outputDirectory>mahout-examples</outputDirectory>-->
+ <outputDirectory>examples</outputDirectory>
<includes>
<include>src/**</include>
<include>pom.xml</include>
@@ -68,14 +69,15 @@
<include>org.apache.mahout:mahout-taste-webapp</include>
</includes>
<binaries>
- <outputDirectory>mahout-taste-webapp</outputDirectory>
+ <outputDirectory>taste-webapp</outputDirectory>
<unpack>false</unpack>
</binaries>
<sources>
+ <outputDirectoryMapping>taste-webapp</outputDirectoryMapping>
<fileSets>
<fileSet>
<!--<directory>taste-web</directory>-->
- <!--<outputDirectory>mahout-taste-webapp</outputDirectory>-->
+ <outputDirectory>taste-webapp</outputDirectory>
<includes>
<include>src/**</include>
<include>pom.xml</include>
@@ -85,4 +87,4 @@
</sources>
</moduleSet>
</moduleSets>
-</assembly>
\ No newline at end of file
+</assembly>
Index: core/pom.xml
===================================================================
--- core/pom.xml (revision 745940)
+++ core/pom.xml (working copy)
@@ -402,8 +402,8 @@
<configuration>
<forkMode>pertest</forkMode>
<argLine>-Xms256m -Xmx512m</argLine>
- <testFailureIgnore>false</testFailureIgnore>
- <skip>false</skip>
+ <!--testFailureIgnore>false</testFailureIgnore-->
+ <!--skip>false</skip-->
<includes />
<excludes />
</configuration>
Index: taste-web/pom.xml
===================================================================
--- taste-web/pom.xml (revision 745940)
+++ taste-web/pom.xml (working copy)
@@ -91,8 +91,8 @@
<configuration>
<forkMode>pertest</forkMode>
<argLine>-Xms256m -Xmx512m</argLine>
- <testFailureIgnore>false</testFailureIgnore>
- <skip>false</skip>
+ <!--testFailureIgnore>false</testFailureIgnore>
+ <skip>false</skip-->
<includes />
<excludes />
</configuration>
Index: taste-web/recommender.properties
===================================================================
--- taste-web/recommender.properties (revision 745940)
+++ taste-web/recommender.properties (working copy)
@@ -1,2 +1,2 @@
#Set this to the Recommender class value.
-recommender.class=CHANGE ME in recommender.properties
\ No newline at end of file
+recommender.class=GenericUserBasedRecommender
Index: examples/pom.xml
===================================================================
--- examples/pom.xml (revision 745940)
+++ examples/pom.xml (working copy)
@@ -112,8 +112,8 @@
<configuration>
<forkMode>pertest</forkMode>
<argLine>-Xms256m -Xmx512m</argLine>
- <testFailureIgnore>false</testFailureIgnore>
- <skip>false</skip>
+ <!--testFailureIgnore>false</testFailureIgnore>
+ <skip>false</skip-->
<includes />
<excludes />
</configuration>
signature.asc
Description: This is a digitally signed message part.
