On Thu, Jun 05, 2003 at 06:11:58PM -0500, Craig A. Berry wrote:
> >I have another idea and will hopefully have a patch out shortly.
> 
> And the idea was the very simple one of moving the dummy-install
> directory up a level so it is a sibling of the t directory. That was
> easy to do, doesn't add complexity, and works fine. The attached patch
> was taken against bleadperl but will apply with -p2 against a standalone
> MakeMaker.

Okay.


> --- lib/ExtUtils/t/basic.t;-0 Fri May 23 09:23:28 2003
> +++ lib/ExtUtils/t/basic.t    Thu Jun  5 12:14:34 2003
> @@ -40,7 +40,7 @@
>  ok( chdir 'Big-Dummy', "chdir'd to Big-Dummy" ) ||
>    diag("chdir failed: $!");
>  
> -my @mpl_out = run(qq{$perl Makefile.PL "PREFIX=dummy-install"});
> +my @mpl_out = run(qq{$perl Makefile.PL "PREFIX=../dummy-install"});
>  
>  cmp_ok( $?, '==', 0, 'Makefile.PL exited with zero' ) ||
>    diag(@mpl_out);
> @@ -119,12 +119,12 @@
>  like( $install_out, qr/^Installing /m );
>  like( $install_out, qr/^Writing /m );
>  
> -ok( -r 'dummy-install',     '  install dir created' );
> +ok( -r '../dummy-install',     '  install dir created' );
>  my %files = ();
>  find( sub { 
>      # do it case-insensitive for non-case preserving OSs
>      $files{lc $_} = $File::Find::name; 
> -}, 'dummy-install' );
> +}, '../dummy-install' );
>  ok( $files{'dummy.pm'},     '  Dummy.pm installed' );
>  ok( $files{'liar.pm'},      '  Liar.pm installed'  );
>  ok( $files{'.packlist'},    '  packlist created'   );
> @@ -172,7 +172,7 @@
>  
>  
>  # Make sure init_dirscan doesn't go into the distdir
> [EMAIL PROTECTED] = run(qq{$perl Makefile.PL "PREFIX=dummy-install"});
> [EMAIL PROTECTED] = run(qq{$perl Makefile.PL "PREFIX=../dummy-install"});
>  
>  cmp_ok( $?, '==', 0, 'Makefile.PL exited with zero' ) || diag(@mpl_out);
>  
> --- lib/ExtUtils/t/zz_cleanup_dummy.t;-0      Sat Apr 12 09:54:18 2003
> +++ lib/ExtUtils/t/zz_cleanup_dummy.t Thu Jun  5 12:23:10 2003
> @@ -12,10 +12,12 @@
>  
>  
>  use strict;
> -use Test::More tests => 2;
> +use Test::More tests => 3;
>  use File::Path;
>  
>  rmtree('Big-Dummy');
>  ok(!-d 'Big-Dummy', 'Big-Dummy cleaned up');
>  rmtree('Problem-Module');
>  ok(!-d 'Problem-Module', 'Problem-Module cleaned up');
> +rmtree('dummy-install');
> +ok(!-d 'dummy-install', 'dummy-install cleaned up');


-- 
HA HA HA  You're all so rediculous!  But thanks for the money!

Reply via email to