[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777476#action_12777476
 ] 

Hemanth Yamijala commented on MAPREDUCE-1140:
---------------------------------------------

Some comments on the test case:

- Can we refactor TestTrackerDistributedCacheManager and its subclass for 
LinuxTaskController, by introducing an API like canRun in the base class. Let 
it return true and this can be overridden in 
TestTrackerDistributedCacheManagerWithLinuxTaskController to return false if 
the platform is not Linux. This way, I suppose we don't have to keep 
overridding every testcase in the base class everytime we make a change.

- I would enhance testReferenceCount to add 3 files instead of 2, the first 
file should be localized correctly, the second should fail after the reference 
count is incremented, and the third will not be localized at all. Then we can 
verify that the reference count for all files is 0.

 

> Per cache-file refcount can become negative when tasks release 
> distributed-cache files
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1140
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1140
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.20.2, 0.21.0, 0.22.0
>            Reporter: Vinod K V
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-1140-1.txt, patch-1140-ydist.txt, patch-1140.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to