[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779869#action_12779869
 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1140:
----------------------------------------------------

test-patch result for Y!20 patch :
{noformat}
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
{noformat}

bq.  -1 tests included. Please justify why no tests are needed for this patch.
It is difficult to write unit test in branch 0.20. Since the code in 
DistributedCache has all static methods, fake objects also can not be used.

All unit tests passed on my machine except TestHdfsProxy.

> Per cache-file refcount can become negative when tasks release 
> distributed-cache files
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1140
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1140
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.20.2, 0.21.0, 0.22.0
>            Reporter: Vinod K V
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-1140-1.txt, patch-1140-2.txt, 
> patch-1140-ydist.txt, patch-1140-ydist.txt, patch-1140.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to