[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777809#action_12777809
 ] 

Jothi Padmanabhan commented on MAPREDUCE-1140:
----------------------------------------------

In {{getLocalCache}}, if the file is already present, only reference count is 
incremented, so does not throw any IOExceptions. If the file is not present, 
{{cachedArchives.put}} is done only after the necessary processing (read 
methods that can throw IOExceptions) is complete. So, I do not think this patch 
will lead to any inconsistency.

I however do agree that it is a good idea to do the refactor of test case to 
avoid duplication.

> Per cache-file refcount can become negative when tasks release 
> distributed-cache files
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1140
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1140
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.20.2, 0.21.0, 0.22.0
>            Reporter: Vinod K V
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-1140-1.txt, patch-1140-ydist.txt, patch-1140.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to