[
https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J Chouraria updated MAPREDUCE-2193:
-----------------------------------------
Attachment: hadoop-findbugs-report.html
mapreduce.trunk.findbugs.r1.diff
Attempting this cause it looks like an interesting task for a newcomer.
Attached a patch that filters and fixes some of these warnings. [Also attached
the resultant warning HTML page].
Please review :)
Regarding the four remaining IS2_INCONSISTENT_SYNC warnings, I'm unable to
think of a proper way to exclude them (as I think getTasks() doesn't require to
be synchronized).
I tried performing a Match on the Method, but findbugs is only interested in
the Field as a whole. Ignoring the Fields (maps, reduces, setup, cleanup) for
the entire JIP class doesn't look like a good idea to me. Any tips on how to
resolve this filtering?
> 13 Findbugs warnings on trunk and branch-0.22
> ---------------------------------------------
>
> Key: MAPREDUCE-2193
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Nigel Daley
> Priority: Blocker
> Fix For: 0.22.0, 0.23.0
>
> Attachments: findbugsWarnings.html, hadoop-findbugs-report.html,
> mapreduce.trunk.findbugs.r1.diff
>
>
> There are 13 findbugs warnings on trunk. See attached html file. These must
> be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS
> property in src/test/test-patch.properties should also be set to 0 in the
> patch that fixes this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
