[
https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J Chouraria updated MAPREDUCE-2193:
-----------------------------------------
Attachment: mapreduce.trunk.findbugs.r3.diff
New patch that tries to resolve Todd's additional comments.
* Adds a new class 'Holder<T>' added in o.a.h.mapreduce package, for use right
now only in Localizer.java. Re-added synchronized block in Localizer.java.
* Removed ignores on maps/reduces/etc TIP arrays in JobInProgress.java and made
the getTasks() method synchronized.
Checkstyle passes on Holder.java with 0 errors/warnings (via the report of `ant
checkstyle`). Findbugs reports 0 errors, like the previous attachment.
> 13 Findbugs warnings on trunk and branch-0.22
> ---------------------------------------------
>
> Key: MAPREDUCE-2193
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Nigel Daley
> Assignee: Harsh J Chouraria
> Priority: Blocker
> Fix For: 0.22.0, 0.23.0
>
> Attachments: findbugsWarnings.html, hadoop-findbugs-report.html,
> hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff,
> mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff
>
>
> There are 13 findbugs warnings on trunk. See attached html file. These must
> be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS
> property in src/test/test-patch.properties should also be set to 0 in the
> patch that fixes this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
