[
https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985946#action_12985946
]
Todd Lipcon commented on MAPREDUCE-2193:
----------------------------------------
Hey Harsh, thanks for making the changes. A few more notes:
- Holder needs the Apache license and an interface annotation - probably Stable
and Private. It should also move into the o.a.h.mapreduce.util package -
o.a.h.mapreduce is for public APIs as far as I understand
- I'd like someone else to take a look at adding 'synchronized' to getTasks()
in addition to me - it's just scary enough that I think an extra reviewer is
prudent.
> 13 Findbugs warnings on trunk and branch-0.22
> ---------------------------------------------
>
> Key: MAPREDUCE-2193
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Nigel Daley
> Assignee: Harsh J Chouraria
> Priority: Blocker
> Fix For: 0.22.0, 0.23.0
>
> Attachments: findbugsWarnings.html, hadoop-findbugs-report.html,
> hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff,
> mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff
>
>
> There are 13 findbugs warnings on trunk. See attached html file. These must
> be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS
> property in src/test/test-patch.properties should also be set to 0 in the
> patch that fixes this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
