[
https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J Chouraria updated MAPREDUCE-2193:
-----------------------------------------
Attachment: mapreduce.trunk.findbugs.r5.diff
New patch (still leaves a couple of sync warnings left, as introduced by
MAPREDUCE-2026).
@Chris - I've made the changes you suggested. Although, even with those
changes, is it required for {{getTasks(TaskType)}} to be sync'd? I've sync'd it
in this patch, but let me know if it can be removed, and the warning ignored
(possibly inaccurate, as admitted by Findbugs).
@Todd - Shall I open a new JIRA for other places Holder<T> may be used at?
The additional two findbug warnings generated by the issue pointed by Priyo
(MAPREDUCE-2026 - Interesting why it does not show up in the test-patch?) needs
to be ignored/re-reviewed as well (for {{getMapCounters}}/{{getReduceCounters}}
are left synchronized - why?).
> 13 Findbugs warnings on trunk and branch-0.22
> ---------------------------------------------
>
> Key: MAPREDUCE-2193
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Nigel Daley
> Assignee: Harsh J Chouraria
> Priority: Blocker
> Fix For: 0.22.0, 0.23.0
>
> Attachments: findbugsWarnings.html, hadoop-findbugs-report.html,
> hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff,
> mapreduce.trunk.findbugs.r2.diff, mapreduce.trunk.findbugs.r3.diff,
> mapreduce.trunk.findbugs.r4.diff, mapreduce.trunk.findbugs.r5.diff
>
>
> There are 13 findbugs warnings on trunk. See attached html file. These must
> be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS
> property in src/test/test-patch.properties should also be set to 0 in the
> patch that fixes this issue.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
