[
https://issues.apache.org/jira/browse/MAPREDUCE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062052#comment-13062052
]
Josh Wills commented on MAPREDUCE-2663:
---------------------------------------
Thanks for cleaning this up!
My only comment is that I think we can do away with the ApplicableTransition
interface entirely, since it is a private, inner interface that just has one
implementation. So why not rename ApplicableSingleOrMultipleTransition ->
ApplicableTransition, and remove the interface definition entirely?
> Refactoring StateMachineFactory inner classes
> ---------------------------------------------
>
> Key: MAPREDUCE-2663
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2663
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Attachments: MAPREDUCE-2663.patch
>
>
> The code for ApplicableSingleTransition and ApplicableMultipleTransition
> inner classes is almost identical. For maintainability, it is better to
> refactor them into a single inner class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
