[
https://issues.apache.org/jira/browse/MAPREDUCE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064027#comment-13064027
]
Hadoop QA commented on MAPREDUCE-2663:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485723/MAPREDUCE-2663.patch
against trunk revision 1145679.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/458//console
This message is automatically generated.
> MR-279: Refactoring StateMachineFactory inner classes
> -----------------------------------------------------
>
> Key: MAPREDUCE-2663
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2663
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2663.patch
>
>
> The code for ApplicableSingleTransition and ApplicableMultipleTransition
> inner classes is almost identical. For maintainability, it is better to
> refactor them into a single inner class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira