[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062143#comment-13062143
 ] 

Ahmed Radwan commented on MAPREDUCE-2663:
-----------------------------------------

Thanks for your review Josh! 
It is generally beneficial to have this interface separation, specially if we 
decided to add other implementations in the future. This was my basic motive 
for keeping the interface.

> Refactoring StateMachineFactory inner classes
> ---------------------------------------------
>
>                 Key: MAPREDUCE-2663
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2663
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>            Priority: Minor
>         Attachments: MAPREDUCE-2663.patch
>
>
> The code for ApplicableSingleTransition and ApplicableMultipleTransition 
> inner classes is almost identical. For maintainability, it is better to 
> refactor them into a single inner class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to