[
https://issues.apache.org/jira/browse/MAPREDUCE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102831#comment-13102831
]
[email protected] commented on MAPREDUCE-2790:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1791/#review1856
-----------------------------------------------------------
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobStatus.java
<https://reviews.apache.org/r/1791/#comment4241>
Because JobStatus is @Public and @Stable I would like to see versions of
the old constructors still there, with containerInfo defaulting to null (Or
something else that is an acceptable default). Otherwise we will break binary
compatibility.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobStatus.java
<https://reviews.apache.org/r/1791/#comment4242>
Even though this one is @Public @Evolving I would still prefer to see
binary compatibility in the constructors.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobStatus.java
<https://reviews.apache.org/r/1791/#comment4243>
I believe that to maintain binary compatibility this line should be moved
to the end of the function. I think this is really only used in the MRV1 code,
but I think it would be cleaner either way. You would need to move the
corresponding read too.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
<https://reviews.apache.org/r/1791/#comment4239>
I agree with Jeff. job.getSchedulingInfo() is at the end of the line but
the "SchedulingInfo" header is second to the last.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
<https://reviews.apache.org/r/1791/#comment4244>
What is the JIRA for this TODO? Who calls this method and how critical is
the container info being absent?
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
<https://reviews.apache.org/r/1791/#comment4240>
I have a bit of a problem with containerInfo. The information being
returned is a string that is already formatted for output on the command line.
I would much rather see a data structure returned, and the formatting happen in
the CLI code. This way if we do want to access that info programmaticly we
don't have to parse a string to get it.
- Robert
On 2011-09-12 16:45:59, Ravi Prakash wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1791/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-12 16:45:59)
bq.
bq.
bq. Review request for Tom Graves, Jeffrey Naisbitt, Robert Evans, and
Jonathan Eagles.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add additional field for storing the AM/job history info on CLI (
https://issues.apache.org/jira/browse/MAPREDUCE-2790 )
bq.
bq.
bq. This addresses bug MAPREDUCE-2790.
bq. https://issues.apache.org/jira/browse/MAPREDUCE-2790
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationReport.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobStatus.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobStatus.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationReportPBImpl.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/BuilderUtils.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
1169819
bq.
bq. Diff: https://reviews.apache.org/r/1791/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ravi
bq.
bq.
> [MR-279] Add additional field for storing the AM/job history info on CLI
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-2790
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2790
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Ramya Sunil
> Assignee: Ravi Prakash
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2790.v1.txt, MAPREDUCE-2790.v2.txt
>
>
> bin/mapred job [-list [all]] displays the AM or job history location in the
> "SchedulingInfo" field. An additional column has to be added to display the
> AM/job history information. Currently, the output reads:
> {noformat}
> JobId State StartTime UserName Queue Priority
> SchedulingInfo
> jobID FAILED 0 ramya default NORMAL AM
> information/job history location
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
