[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103101#comment-13103101
 ] 

[email protected] commented on MAPREDUCE-2790:
----------------------------------------------------------



bq.  On 2011-09-12 16:56:37, Jeffrey Naisbitt wrote:
bq.  > Also, have you run all the tests and grep'd through the code to make 
sure you've fixed all the places that implement the ApplicationReport interface?
bq.  > I also noticed that ApplicationReport is declared as @Public and 
@Stable, so there may be public documentation and such that needs to be updated 
(assuming we're ok with modifying a "@Stable" interface since we haven't 
actually pushed out any releases yet).

I did run test-patch. There is only one implementation of ApplicationReport and 
I did update that (ApplicationReportPBImpl). I'm afraid I didn't see a 
practical alternative to provide this functionality without changing a Stable 
interface. I grepd for ApplicationReport and couldn't find any non-java 
documentation files.


bq.  On 2011-09-12 16:56:37, Jeffrey Naisbitt wrote:
bq.  > 
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java,
 lines 530-535
bq.  > <https://reviews.apache.org/r/1791/diff/2/?file=40113#file40113line530>
bq.  >
bq.  >     I think you need to either print the container info after the 
scheduling info here, or you need to change the order you print the headers

In short, the switcheroo is intentional.
In long: One of the changes requested by Ramya was for Scheduling Info to 
display the information analogous to what is displayed in 0.20. This is 
provided by the getContainerInfo(). getSchedulingInfo() provides the URL for 
the AM. (the AM info).


- Ravi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1791/#review1855
-----------------------------------------------------------


On 2011-09-12 16:45:59, Ravi Prakash wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1791/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-12 16:45:59)
bq.  
bq.  
bq.  Review request for Tom Graves, Jeffrey Naisbitt, Robert Evans, and 
Jonathan Eagles.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Add additional field for storing the AM/job history info on CLI ( 
https://issues.apache.org/jira/browse/MAPREDUCE-2790 )
bq.  
bq.  
bq.  This addresses bug MAPREDUCE-2790.
bq.      https://issues.apache.org/jira/browse/MAPREDUCE-2790
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationReport.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobStatus.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobStatus.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationReportPBImpl.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/BuilderUtils.java
 1169819 
bq.    
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
 1169819 
bq.  
bq.  Diff: https://reviews.apache.org/r/1791/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ravi
bq.  
bq.



> [MR-279] Add additional field for storing the AM/job history info on CLI
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2790
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2790
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Ramya Sunil
>            Assignee: Ravi Prakash
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2790.v1.txt, MAPREDUCE-2790.v2.txt
>
>
> bin/mapred job [-list [all]] displays the AM or job history location in the 
> "SchedulingInfo" field. An additional column has to be added to display the 
> AM/job history information. Currently, the output reads:
> {noformat}
> JobId   State   StartTime       UserName        Queue   Priority        
> SchedulingInfo
> jobID  FAILED       0           ramya           default NORMAL      AM 
> information/job history location
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to