[
https://issues.apache.org/jira/browse/MAPREDUCE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103105#comment-13103105
]
[email protected] commented on MAPREDUCE-2790:
----------------------------------------------------------
bq. On 2011-09-12 17:35:34, Robert Evans wrote:
bq. >
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobStatus.java,
line 99
bq. > <https://reviews.apache.org/r/1791/diff/2/?file=40111#file40111line99>
bq. >
bq. > Because JobStatus is @Public and @Stable I would like to see
versions of the old constructors still there, with containerInfo defaulting to
null (Or something else that is an acceptable default). Otherwise we will
break binary compatibility.
Which binary compatibility are we talking about here? Between which two
versions? The constructor signatures have been changed significantly between
0.20 and 0.23 already. 0.23 hasn't been released yet.
JobStatus in 0.23 is quite far removed from that in 0.20. In my opinion I think
we should mark these interfaces as unstable for some time.
bq. On 2011-09-12 17:35:34, Robert Evans wrote:
bq. >
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java,
line 304
bq. > <https://reviews.apache.org/r/1791/diff/2/?file=40119#file40119line304>
bq. >
bq. > I have a bit of a problem with containerInfo. The information being
returned is a string that is already formatted for output on the command line.
I would much rather see a data structure returned, and the formatting happen in
the CLI code. This way if we do want to access that info programmaticly we
don't have to parse a string to get it.
I was ambivalent about this too. (I started off with an int being passed).
Ideally I'd like to see what resources are being used by a job currently. As we
add other attributes to containers, the data structure you proposed will have
to be modified (to include CPU / disk etc). Furthermore it provides no tangible
benefit. Having a String being formulated at the resource manager gives the
resource manager the freedom to describe the resource allocation in its own
terms rather than the Clients having to interpret data structures.
bq. On 2011-09-12 17:35:34, Robert Evans wrote:
bq. >
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java,
line 312
bq. > <https://reviews.apache.org/r/1791/diff/2/?file=40114#file40114line312>
bq. >
bq. > What is the JIRA for this TODO? Who calls this method and how
critical is the container info being absent?
The commit that introduced the TODO line corresponds to
https://issues.apache.org/jira/browse/MAPREDUCE-2807. I did not find an
associated JIRA. Do we have JIRAs associated to all the TODO's in code? We
should. And then reference them in the TODO line. But I'm afraid I couldn't
find a JIRA corresponding to this line.
- Ravi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1791/#review1856
-----------------------------------------------------------
On 2011-09-12 16:45:59, Ravi Prakash wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1791/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-12 16:45:59)
bq.
bq.
bq. Review request for Tom Graves, Jeffrey Naisbitt, Robert Evans, and
Jonathan Eagles.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add additional field for storing the AM/job history info on CLI (
https://issues.apache.org/jira/browse/MAPREDUCE-2790 )
bq.
bq.
bq. This addresses bug MAPREDUCE-2790.
bq. https://issues.apache.org/jira/browse/MAPREDUCE-2790
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationReport.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobStatus.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobStatus.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationReportPBImpl.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/BuilderUtils.java
1169819
bq.
trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java
1169819
bq.
bq. Diff: https://reviews.apache.org/r/1791/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ravi
bq.
bq.
> [MR-279] Add additional field for storing the AM/job history info on CLI
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-2790
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2790
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Ramya Sunil
> Assignee: Ravi Prakash
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2790.v1.txt, MAPREDUCE-2790.v2.txt
>
>
> bin/mapred job [-list [all]] displays the AM or job history location in the
> "SchedulingInfo" field. An additional column has to be added to display the
> AM/job history information. Currently, the output reads:
> {noformat}
> JobId State StartTime UserName Queue Priority
> SchedulingInfo
> jobID FAILED 0 ramya default NORMAL AM
> information/job history location
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
