[
https://issues.apache.org/jira/browse/MAPREDUCE-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290915#comment-13290915
]
Ivan Mitic commented on MAPREDUCE-4260:
---------------------------------------
This is a great change, thanks Bikas!
A have a few minor questions/suggestions:
1. ProcessTree.java: {{ProcessTree.isSetsidSupported}} Do we have to check for
"Create a new task..." string existence before we can enable setsid? It is not
intuitive that one has to change another place in code if it changes winutils
output. If you still need this check, can you please put a comment in winutils
to call this out.
2. ProcessTree.java: It might be useful to log if setsid functionality is not
available.
3. JobConf.java: Is there a scenario where one wouldn't want to use JobObjects
on Windows?
4. task.c:197 Missing a check on whether {{LocalAlloc}} succeeded
5. task.c:201 Didn't get the motivation for doing {{ERROR_MORE_DATA}} check?
Will {{procList->NumberOfAssignedProcesses}} be valid in case of this error?
> Investigate use of JobObject to spawn tasks on Windows
> ------------------------------------------------------
>
> Key: MAPREDUCE-4260
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4260
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: MAPREDUCE-4260.branch-1-win.patch, MAPREDUCE-4260.patch,
> test.cpp
>
>
> Currently, the Windows version spawns the task as a normal cmd shell from
> which other downstream exe's are spawned. However, this is not bullet proof
> because if an intermediate process exits before its child exits, then the
> parent child process tree relationship cannot be constructed. Windows has a
> concept of JobObject that is similar to the setsid behavior used in Linux.
> The initial spawned task could be launched within its JobObject. Thereafter,
> process termination, memory management etc could be operated on the JobObject.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
