[
https://issues.apache.org/jira/browse/MAPREDUCE-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396594#comment-13396594
]
Ivan Mitic commented on MAPREDUCE-4203:
---------------------------------------
Change looks good Bikas!
I have some minor comments/questions/suggestions:
1. WindowsBasedProcessTree.java:114: Should the new age be oldAge+1 same as in
ProfsBasedProcessTree?
2. LinuxResourceCalculatorPlugin.java:399: Do we need this code: {code}
if(processPid == null) {
// process pid not set. try to obtain on our own
processPid = System.getenv().get("JVM_PID");
}
{code} processPid should have been initialized. If not initialized in all
cases, we might have a problem on Windows. To harden the code, might make sense
to add a null check for processPid in
{{WindowsResourceCalculatorPlugin#getProcResourceValues}} and log an error if
processPid is undefined.
3. Should {{ResourceCalculatorPlugin#getResourceCalculatorPlugin()}} fallback
to {{WindowsResourceCalculatorPlugin}} on Windows?
4. task.c:335 From documentation, it seems that PagefileUsage is always zero on
Windows Server 2008, use PrivateUsage instead?
5. main.c:100: Would you mind updating {{Usage()}} function with information on
"systeminfo"? Please include information on the format of the output, as it’s
hard to figure out. Same comment for {{task.c!TaskUsage()}}
6. systeminfo.c: Can you please print error info via {{ReportErrorCode()}} when
calls into Windows APIs fail?
> Create equivalent of ProcfsBasedProcessTree for Windows
> -------------------------------------------------------
>
> Key: MAPREDUCE-4203
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4203
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: MAPREDUCE-4203.branch-1-win.1.patch,
> MAPREDUCE-4203.branch-1-win.2.patch, MAPREDUCE-4203.patch, test.cpp
>
>
> ProcfsBasedProcessTree is used by the TaskTracker to get process information
> like memory and cpu usage. This information is used to manage resources etc.
> The current implementation is based on Linux procfs functionality and hence
> does not work on other platforms, specifically windows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
