[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397252#comment-13397252
 ] 

Chuan Liu commented on MAPREDUCE-4203:
--------------------------------------

# {quote}
I would prefer the secure and generic versions unless you have a strong 
preference for the wide char version
{quote}
You can use fwprintf_s(). I am fine if you want to stay with tchar version. It 
is just implementation wise, tchar functions are always mapped to either 
Unicode/wchar version or ANSI version. E.g. we have the following definition in 
"tchar.h". Because we have explicitly indicate we only support Unicode. I think 
it more clear if we always use wide char version of the functions. Either way, 
since they are equivalent, it is your call.
{code}
#define _ftprintf_s     fwprintf_s
{code}
# For ReportErrorCode(), it is because we are calling FormatMessageW() inside 
the function to retrieval the [system error 
code|http://msdn.microsoft.com/en-us/library/windows/desktop/ms681382.aspx] 
message inside the function. If you pass in EXIT_FAILURE (1), it will print 
error message of ERROR_INVALID_FUNCTION (1). 
                
> Create equivalent of ProcfsBasedProcessTree for Windows
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-4203
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4203
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: MAPREDUCE-4203.branch-1-win.1.patch, 
> MAPREDUCE-4203.branch-1-win.2.patch, MAPREDUCE-4203.branch-1-win.3.patch, 
> MAPREDUCE-4203.patch, test.cpp
>
>
> ProcfsBasedProcessTree is used by the TaskTracker to get process information 
> like memory and cpu usage. This information is used to manage resources etc. 
> The current implementation is based on Linux procfs functionality and hence 
> does not work on other platforms, specifically windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to