[
https://issues.apache.org/jira/browse/MAPREDUCE-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397199#comment-13397199
]
Chuan Liu commented on MAPREDUCE-4203:
--------------------------------------
[~bikassaha], change looks good! I just have following two minor suggestions
for 'SystemInfo.c' based on branch-1-win.3.patch.
# Use fwprintf() instead of _ftprintf_s(). Because we have UNICODE defined,
they should be the same. It is just fwprintf() makes things more clear in my
opinion.
# ReportErrorCode() was designed to be used with system error codes. So it
would be better to just print an custom error message instead of calling it
with EXIT_FAILURE as follows.
{code}
ReportErrorCode(L"CallNtPowerInformation", EXIT_FAILURE);
{code}
> Create equivalent of ProcfsBasedProcessTree for Windows
> -------------------------------------------------------
>
> Key: MAPREDUCE-4203
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4203
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: MAPREDUCE-4203.branch-1-win.1.patch,
> MAPREDUCE-4203.branch-1-win.2.patch, MAPREDUCE-4203.branch-1-win.3.patch,
> MAPREDUCE-4203.patch, test.cpp
>
>
> ProcfsBasedProcessTree is used by the TaskTracker to get process information
> like memory and cpu usage. This information is used to manage resources etc.
> The current implementation is based on Linux procfs functionality and hence
> does not work on other platforms, specifically windows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
