[
https://issues.apache.org/jira/browse/MAPREDUCE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502613#comment-14502613
]
Hadoop QA commented on MAPREDUCE-5733:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726540/MAPREDUCE-5733_2.patch
against trunk revision c17cd4f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5414//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5414//console
This message is automatically generated.
> Define and use a constant for property "textinputformat.record.delimiter"
> -------------------------------------------------------------------------
>
> Key: MAPREDUCE-5733
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5733
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Gelesh
> Assignee: Gelesh
> Priority: Trivial
> Attachments: MAPREDUCE-5733.patch, MAPREDUCE-5733_2.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") ,
> is bound to typo error. Lets have it as a Static String in some class, to
> minimise such error. This would also help in IDE like eclipse suggesting the
> String.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
