[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506465#comment-14506465
 ] 

Gelesh commented on MAPREDUCE-5733:
-----------------------------------

 to use a single public constant, which class and package it should belong ?
I thing if Map Red is also to be fixed we need to place a seperate similar 
static final decleration.
Instead if we would use a single refrence in any one package either mapred or 
mapreduce the users of other package would be forced to have a import statment 
just to accesss this string call.  

> Define and use a constant for property "textinputformat.record.delimiter"
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5733
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5733
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Gelesh
>            Assignee: Gelesh
>            Priority: Trivial
>         Attachments: MAPREDUCE-5733.patch, MAPREDUCE-5733_2.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , 
> is bound to typo error. Lets have it as a Static String in some class, to 
> minimise such error. This would also help in IDE like eclipse suggesting the 
> String.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to