[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502626#comment-14502626
 ] 

Gelesh commented on MAPREDUCE-5733:
-----------------------------------

This feature could be tested using a MR Unit, or with a get and set on 
Configuration object like
conf.set(TextInputFormat.DELIMITER,"</record>") 
Asset(conf.get("textInputFormat.record.delimiter","</record>")

Since its just a Static variable decleration, I dont think we need to place a 
test case for the same.

> Define and use a constant for property "textinputformat.record.delimiter"
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5733
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5733
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Gelesh
>            Assignee: Gelesh
>            Priority: Trivial
>         Attachments: MAPREDUCE-5733.patch, MAPREDUCE-5733_2.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , 
> is bound to typo error. Lets have it as a Static String in some class, to 
> minimise such error. This would also help in IDE like eclipse suggesting the 
> String.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to