> On March 9, 2015, 8:35 p.m., Dennis Nienhüser wrote: > > Good catch. Can you also extend the current TestEquality::polygonTest() in > > tests/TestEquality.cpp such that it fails unless your patch is applied?
Sure. Done! - Boris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122854/#review77229 ----------------------------------------------------------- On March 10, 2015, 4:32 a.m., Boris Egorov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122854/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 4:32 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > We should compare GeoDataLinearRing's of different GeoDataPolygon's, not > one with itself. Check that in TestEquality::polygonTest(). > > Issue detected by Cppcheck: "Same expression on both sides of '!='." > > > Diffs > ----- > > src/lib/marble/geodata/data/GeoDataPolygon.cpp 9ae7091 > tests/TestEquality.cpp a3f5498 > > Diff: https://git.reviewboard.kde.org/r/122854/diff/ > > > Testing > ------- > > > Thanks, > > Boris Egorov > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
